This repository has been archived by the owner on Nov 1, 2023. It is now read-only.
Don't consume S_LABEL symbols from PDBs
#3046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should be a conservative change: the coverage "denominator" may decrease for some targets, but we eliminate the bug class of label symbol misinterpretation. |
Codecov Report
@@ Coverage Diff @@
## main #3046 +/- ##
=======================================
Coverage 31.42% 31.43%
=======================================
Files 306 306
Lines 36633 36627 -6
=======================================
Hits 11513 11513
+ Misses 25120 25114 -6
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
ranweiler
commented
Apr 20, 2023
Porges
approved these changes
Apr 20, 2023
|
@Porges, I no longer have perms to merge this, but integration tests look good. |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows, label symbols (see here, here) are used to extend the initial set of basic block entrypoint offsets, augmenting function entrypoints. We expect these labels to describe instruction locations, and never procedure-local data or tables.
In practice, this doesn't always hold. We may be able to re-enable this feature in the future, but we'll need a reliable procedure for identifying true code labels (dereferencing to an x86 instruction is insufficient), so disable this hinting for now.