Skip to content
This repository has been archived by the owner on Nov 1, 2023. It is now read-only.

Initial Custom Metrics - Node & Task Heartbeat #3082

Merged

Conversation

nharper285
Copy link
Contributor

@nharper285 nharper285 commented May 3, 2023

Summary of the Pull Request

What is this about?
In order to improve the reliability of OneFuzz's telemetry - and therefore the Grafana data dashboards that rely on it - we are pursuing a refactor that makes use of App Insight's CustomMetrics type. These metrics are, importantly, not sampled and will offer us a more consistent monitoring type without fear of sampling.

In order to centralize and standardize the CustomMetric format, we are making use of a set of 'metrics' types and functions. Funneling all of the logging through this one source will allow us to keep better track of the creation of the actual metric and, again, standardize the metric's format - name, value, custom dimensions.

To start, I have implemented custom metrics for the node_heartbeat event and the task_heartbeat event.

PR Checklist

Info on Pull Request

What does this include?

  • New 'metrics' types
  • node and task heartbeat metrics

Validation Steps Performed

How does someone test & validate?

@nharper285 nharper285 requested a review from mgreisen May 5, 2023 21:09
@nharper285 nharper285 marked this pull request as ready for review May 11, 2023 22:13
@nharper285 nharper285 merged commit d84b72b into microsoft:main May 16, 2023
@nharper285 nharper285 mentioned this pull request May 23, 2023
@mgreisen mgreisen linked an issue Jun 16, 2023 that may be closed by this pull request
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Task Heartbeat *Telemetry*
4 participants