This repository has been archived by the owner on Nov 1, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 199
Initial Custom Metrics - Node & Task Heartbeat #3082
Merged
nharper285
merged 55 commits into
microsoft:main
from
nharper285:user/noharper/custom-metrics-refactor-fork
May 16, 2023
Merged
Initial Custom Metrics - Node & Task Heartbeat #3082
nharper285
merged 55 commits into
microsoft:main
from
nharper285:user/noharper/custom-metrics-refactor-fork
May 16, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…b.com/nharper285/onefuzz into user/noharper/custom-metrics-refactor
…b.com/nharper285/onefuzz into user/noharper/custom-metrics-refactor
chkeita
reviewed
May 8, 2023
chkeita
reviewed
May 8, 2023
…github.com/nharper285/onefuzz into user/noharper/custom-metrics-refactor-fork
…github.com/nharper285/onefuzz into user/noharper/custom-metrics-refactor-fork
…github.com/nharper285/onefuzz into user/noharper/custom-metrics-refactor-fork
chkeita
reviewed
May 11, 2023
chkeita
approved these changes
May 11, 2023
chkeita
reviewed
May 16, 2023
tevoinea
approved these changes
May 16, 2023
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
What is this about?
In order to improve the reliability of OneFuzz's telemetry - and therefore the Grafana data dashboards that rely on it - we are pursuing a refactor that makes use of App Insight's CustomMetrics type. These metrics are, importantly, not sampled and will offer us a more consistent monitoring type without fear of sampling.
In order to centralize and standardize the CustomMetric format, we are making use of a set of 'metrics' types and functions. Funneling all of the logging through this one source will allow us to keep better track of the creation of the actual metric and, again, standardize the metric's format - name, value, custom dimensions.
To start, I have implemented custom metrics for the node_heartbeat event and the task_heartbeat event.
PR Checklist
Info on Pull Request
What does this include?
Validation Steps Performed
How does someone test & validate?