Skip to content
This repository has been archived by the owner on Nov 1, 2023. It is now read-only.

Fix logic of marking task as failed #3083

Merged
merged 7 commits into from
May 4, 2023
Merged

Fix logic of marking task as failed #3083

merged 7 commits into from
May 4, 2023

Conversation

chkeita
Copy link
Contributor

@chkeita chkeita commented May 3, 2023 •
edited
Loading

  • Do not mark task as failed if it is already in the shutting down state
  • accumulate errors when setting task error to understand the context
  • refactor the Error record

closes #3084

chkeita added 3 commits May 3, 2023 12:03
@chkeita
Fix logic of markaing task as failed
665ed63 
- Do not mark task as failed if it is already in the shutting down state
- accumulate errors when setting task error to understand the context
- refactor the Error record
@chkeita
fix tests
09c3ef7
@chkeita
format
457f1c6
@chkeita chkeita changed the title Fix logic of markaing task as failed Fix logic of marking task as failed May 3, 2023
@codecov-commenter
Copy link

codecov-commenter commented May 3, 2023 •
edited
Loading

Codecov Report

Merging #3083 (6a49e0f) into main (d237563) will decrease coverage by 0.03%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##             main    #3083      +/-   ##
==========================================
- Coverage   31.78%   31.75%   -0.03%     
==========================================
  Files         307      307              
  Lines       36814    36770      -44     
==========================================
- Hits        11700    11678      -22     
+ Misses      25114    25092      -22
Impacted Files Coverage Δ
...piService/ApiService/Functions/AgentCanSchedule.cs 0.00% <0.00%> (ø)
.../ApiService/Functions/Migrations/JinjaToScriban.cs 80.00% <0.00%> (ø)
...c/ApiService/ApiService/Functions/NodeAddSshKey.cs 0.00% <0.00%> (ø)
...c/ApiService/ApiService/Functions/Notifications.cs 0.00% <0.00%> (ø)
src/ApiService/ApiService/Functions/Proxy.cs 0.00% <0.00%> (ø)
src/ApiService/ApiService/Functions/Scaleset.cs 40.74% <0.00%> (+1.45%) ⬆️
src/ApiService/ApiService/Functions/Tasks.cs 22.22% <0.00%> (ø)
src/ApiService/ApiService/Functions/WebhookLogs.cs 0.00% <0.00%> (ø)
src/ApiService/ApiService/Functions/WebhookPing.cs 0.00% <0.00%> (ø)
src/ApiService/ApiService/Functions/Webhooks.cs 0.00% <0.00%> (ø)
... and 25 more

@chkeita chkeita requested review from tevoinea and Porges May 3, 2023 19:59
chkeita and others added 3 commits May 4, 2023 12:18
@chkeita @Porges
Update src/ApiService/ApiService/onefuzzlib/ImageReference.cs
a1c5f7f 
Co-authored-by: George Pollard <porges@porg.es>
@chkeita @tevoinea
Update src/ApiService/ApiService/onefuzzlib/ProxyOperations.cs
1e78e9d 
Co-authored-by: Teo Voinea <58236992+tevoinea@users.noreply.github.com>
@chkeita
Merge branch 'main' into bug_fix2
6a49e0f
@chkeita chkeita enabled auto-merge (squash) May 4, 2023 19:18
@chkeita chkeita merged commit bb1a544 into microsoft:main May 4, 2023
@AdamL-Microsoft AdamL-Microsoft mentioned this pull request May 4, 2023
Merged
@nharper285 nharper285 mentioned this pull request May 23, 2023
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tevoinea tevoinea tevoinea approved these changes

@Porges Porges Porges approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix logic of marking task as failed
4 participants
@chkeita @codecov-commenter @Porges @tevoinea