Skip to content
This repository has been archived by the owner on Nov 1, 2023. It is now read-only.

Skip entire function if entry offset excluded #3172

Merged
merged 4 commits into from
Jun 9, 2023

Conversation

ranweiler
Copy link
Member

Closes #3170.

@codecov-commenter
Copy link

codecov-commenter commented Jun 7, 2023

Codecov Report

Merging #3172 (66575f2) into main (300a3e2) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #3172      +/-   ##
==========================================
- Coverage   29.61%   29.60%   -0.01%     
==========================================
  Files         332      332              
  Lines       38890    38902      +12     
==========================================
  Hits        11516    11516              
- Misses      27374    27386      +12     
Impacted Files Coverage Δ
src/agent/coverage/src/binary.rs 70.29% <0.00%> (-9.48%) ⬇️

@ranweiler
Copy link
Member Author

Locally tested that source allowlist exclusion now short-circuits function analysis. Integration tests pass.

@tevoinea tevoinea enabled auto-merge (squash) June 9, 2023 19:04
@tevoinea tevoinea merged commit a040aa2 into microsoft:main Jun 9, 2023
@AdamL-Microsoft AdamL-Microsoft mentioned this pull request Jun 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Apply source allowlists to function entrypoint before disassembly
5 participants