Skip to content
This repository has been archived by the owner on Nov 1, 2023. It is now read-only.

Require input marker in args when given corpus dir #3205

Merged
merged 2 commits into from
Jun 20, 2023

Conversation

ranweiler
Copy link
Member

Fail fast if the user passes an input corpus directory, but doesn't include an input marker (@@) in the command to execute. Before, this resulted in either an immediate spurious exit or, in the case of libFuzzer targets, a guaranteed timeout.

@codecov-commenter
Copy link

codecov-commenter commented Jun 20, 2023

Codecov Report

Merging #3205 (70a83ad) into main (f1af0ba) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #3205   +/-   ##
=======================================
  Coverage   29.53%   29.53%           
=======================================
  Files         332      332           
  Lines       39060    39060           
=======================================
  Hits        11535    11535           
  Misses      27525    27525           

@ranweiler
Copy link
Member Author

Tested all combinations of -d present/absent and @@ present/absent in command args.

@tevoinea tevoinea merged commit a1e331a into microsoft:main Jun 20, 2023
@ranweiler ranweiler deleted the record-arg-check branch June 20, 2023 20:59
@AdamL-Microsoft AdamL-Microsoft mentioned this pull request Jun 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants