Storing secrets in azure keyvault

[chkeita]

No description provided.

[bmc-msft]

Should we hold off on reviewing this while you're working on #349?

[chkeita]

Should we hold off on reviewing this while you're working on #349?

yes i will convert this back into a draft to avoid any confusions

[bmc-msft]

Testing with Teams integration results in the following error:

Microsoft.Azure.WebJobs.Host.FunctionInvocationException: Exception while executing function: Functions.queue_file_changes
 ---> Microsoft.Azure.WebJobs.Script.Workers.Rpc.RpcException: Result: Failure
Exception: AttributeError: 'str' object has no attribute 'value'
Stack:   File "/azure-functions-host/workers/python/3.7/LINUX/X64/azure_functions_worker/dispatcher.py", line 357, in _handle__invocation_request
    self.__run_sync_func, invocation_id, fi.func, args)
  File "/usr/local/lib/python3.7/concurrent/futures/thread.py", line 57, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/azure-functions-host/workers/python/3.7/LINUX/X64/azure_functions_worker/dispatcher.py", line 542, in __run_sync_func
    return func(**params)
  File "/home/site/wwwroot/queue_file_changes/__init__.py", line 34, in main
    file_added(event)
  File "/home/site/wwwroot/queue_file_changes/__init__.py", line 22, in file_added
    new_files(container, path)
  File "/home/site/wwwroot/onefuzzlib/notifications/main.py", line 138, in new_files
    notify_teams(notification.config, container, filename, report)
  File "/home/site/wwwroot/onefuzzlib/notifications/teams.py", line 130, in notify_teams
    send_teams_webhook(config, title, facts, text)
  File "/home/site/wwwroot/onefuzzlib/notifications/teams.py", line 50, in send_teams_webhook
    config_url = get_secret_string_value(config.url)
  File "/home/site/wwwroot/onefuzzlib/secrets.py", line 39, in get_secret_string_value
    return cast(str, secret.value)

My notification config is:

[
    {
        "config": {
            "url": {
                "secret": {
                    "url": "https://INSTANCE_NAME_HERE.vault.azure.net/secrets/3b26a03b-cb51-4722-9ad4-fa94f9ee8c7c/1833f0a96d504574b8b614a69f6c57c1"
                }
            }
        },
        "container": "oft-unique-reports-fc60e3f7cb2f58a692e7ee189f6d113c",
        "notification_id": "479ed0b4-473c-4501-aba1-99f21372ff02"
    }
]