Skip to content
This repository has been archived by the owner on Nov 1, 2023. It is now read-only.

remove early-exit from cleanup_nodes that broke dead node cleanup #458

Merged
merged 5 commits into from
Jan 22, 2021

Conversation

bmc-msft
Copy link
Contributor

Fixes #456

@ghost
Copy link

ghost commented Jan 22, 2021

Hello @bmc-msft!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 18 hours, a condition that will be fulfilled in about 16 hours 13 minutes. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@bmc-msft bmc-msft merged commit e4ecf7e into microsoft:main Jan 22, 2021
@bmc-msft bmc-msft deleted the allow-dead-node-cleanup branch January 28, 2021 18:36
@ghost ghost locked as resolved and limited conversation to collaborators Apr 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

reimaging of dead nodes only happens if there are other nodes to get reimaged
3 participants