Skip to content
This repository has been archived by the owner on Nov 1, 2023. It is now read-only.

add info to help clarify success after warnings #629

Merged
merged 4 commits into from
Mar 3, 2021

Conversation

bmc-msft
Copy link
Contributor

@bmc-msft bmc-msft commented Mar 3, 2021

During a deployment this morning, AAD failed the first attempt to create an application password and upon retry succeeded.

The error message given by AAD was scary:

WARNING:root:unable to create app password: request did not succeed: HTTP 403 - {
  "error": {
    "code": "Authorization_RequestDenied",
    "message": "Insufficient privileges to complete the operation.",
    "innerError": {
      "date": "2021-03-03T15:39:35",
      "request-id": "GUID",
      "client-request-id": "GUID"
    }
  }
}

This error gave me the impression that the AAD password creation failed, yet the deployment continued.

This PR adds a comment in the success case to clarify when the password creation succeeded.

Now, the above case will look like this:

WARNING:root:unable to create app password: request did not succeed: ...
INFO:root:app password created

src/deployment/registration.py Show resolved Hide resolved
@bmc-msft bmc-msft merged commit d2e6c29 into microsoft:main Mar 3, 2021
@bmc-msft bmc-msft deleted the clarify-app-created-for-warnings branch March 3, 2021 20:20
@ghost ghost locked as resolved and limited conversation to collaborators Apr 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants