This repository has been archived by the owner on Nov 1, 2023. It is now read-only.
add info to help clarify success after warnings #629
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During a deployment this morning, AAD failed the first attempt to create an application password and upon retry succeeded.
The error message given by AAD was scary:
This error gave me the impression that the AAD password creation failed, yet the deployment continued.
This PR adds a comment in the success case to clarify when the password creation succeeded.
Now, the above case will look like this: