This repository has been archived by the owner on Nov 1, 2023. It is now read-only.
Fix incorrect offset in stack reports #658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmc-msft
approved these changes
Mar 10, 2021
|
I assume this changes the OneFuzz crash reports / hashes, due to the changed PC? |
|
Yes, it could, but I don't think the hashing is used for libfuzzer tasks. Note that my other PR definitely changes the stack hashes as we use the default Rust generated hash impl and I changed the struct to include the offset. |
|
@bmc-msft: I verified that this PR does change the function-relative offsets of stack frames with no source info (e.g. from |
|
Note that a Windows update would just as easily change the hash for such stacks. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The wrong PC was from the context record and incorrectly adjusted by 1 which worked well enough to see the correct function name and line numbers, but was the wrong offset.
The correct PC is passed in a STACKFRAME_EX struct.