add log checking to refactored integration check #700
Conversation
| @@ -214,9 +214,6 @@ def on_worker_event_done(machine_id: UUID, event: WorkerDoneEvent) -> Result[Non | |||
| node.debug_keep_node = True | |||
| node.save() | |||
| else: | |||
| logging.error( | |||
There was a problem hiding this comment.
note, this is now handled by task.mark_failed. Since we don't record errors on tasks already marked as failures, this moves the error longing to model our state handling.
| @@ -136,7 +136,7 @@ def get_extension(vm_name: str, extension_name: str) -> Optional[Any]: | |||
| resource_group, vm_name, extension_name | |||
| ) | |||
| except (ResourceNotFoundError, CloudError) as err: | |||
| logging.error("extension does not exist %s", err) | |||
| logging.info("extension does not exist %s", err) | |||
There was a problem hiding this comment.
this is common place when we're deploying VMs. shouldn't be an error.
| notifications = get_notifications(container) | ||
|
|
||
| report = get_report_or_regression( |
There was a problem hiding this comment.
since we're going to try to inspect every new file as a potential report, this sets up the parsing (seen later in this PR) to only log errors if we actually expect the files to be a report, rather than just optimistically being a report.
| @@ -205,6 +205,8 @@ def mark_failed( | |||
| ) | |||
| return | |||
|
|
|||
| logging.error("task failed %s:%s - %s", self.job_id, self.task_id, error) | |||
There was a problem hiding this comment.
See previous comment about mark_failed.
|
Hello @bmc-msft! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit 
ghost
locked as resolved and limited conversation to collaborators
In practice, Application Insights can take up to 3 minutes before something sent to it is available via KQL.
This PR logs a start and stop marker such that the integration tests only search for logs during the integration tests. This reduces the complexity when using the integration tests during the development process.
Note: this migrated the new functionality from #356 into the latest integration test tools.