Skip to content
This repository has been archived by the owner on Nov 1, 2023. It is now read-only.

run until end of LLVMFuzzerTestOneInput for collecting coverage #713

Merged

Conversation

bmc-msft
Copy link
Contributor

As is, we ran the libfuzzer target until NtTerminateProcess. For the DLLs that got auto-unloaded, this doesn't record the coverage.

Instead, this moves to breaking on return from LLVMFuzzerTestOneInput, which allows gathering coverage for the DLLs that are auto-unloading on the targets in question.

@bmc-msft bmc-msft requested a review from ranweiler March 22, 2021 22:06
Co-authored-by: Joe Ranweiler <joe@lemma.co>
@ghost
Copy link

ghost commented Mar 22, 2021

Hello @bmc-msft!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 18 hours, a condition that will be fulfilled in about 16 hours 45 minutes. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@bmc-msft bmc-msft linked an issue Mar 23, 2021 that may be closed by this pull request
@bmc-msft bmc-msft merged commit 2b61256 into microsoft:main Mar 23, 2021
@bmc-msft bmc-msft deleted the record-coverage-after-llvmfuzzertestoneinput branch March 23, 2021 15:08
@ghost ghost locked as resolved and limited conversation to collaborators Apr 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LibFuzzer coverage task fails for x86 binaries
3 participants