Skip to content
This repository has been archived by the owner on Nov 1, 2023. It is now read-only.

address telemetry log message locality #736

Merged
merged 7 commits into from
Mar 26, 2021

Conversation

bmc-msft
Copy link
Contributor

Prior to this fix, all logging would show up as:

[2021-03-26T19:53:31Z INFO  onefuzz_telemetry] Starting libFuzzer crash report task

This moves the actual calls to log::log!() to the macros, which puts it in the source file in question.

Now the events look like:

[2021-03-26T21:20:14Z INFO  onefuzz_agent::tasks::report::libfuzzer_report] Starting libFuzzer crash report task

Most importantly, this allows us to use env_logger's ability to filter on a per module basis in a meaningful fashion. As an example, this allows:

RUST_LOG="info,onefuzz::syncdir=warn,onefuzz_agent::tasks::fuzz::libfuzzer=warn"

@bmc-msft bmc-msft requested a review from ranweiler March 26, 2021 21:24
src/agent/onefuzz-agent/src/tasks/stats/common.rs Outdated Show resolved Hide resolved
src/agent/onefuzz-telemetry/src/lib.rs Show resolved Hide resolved
src/agent/onefuzz-telemetry/src/lib.rs Outdated Show resolved Hide resolved
@bmc-msft bmc-msft merged commit dc9b6fa into microsoft:main Mar 26, 2021
@bmc-msft bmc-msft deleted the address-telemetry-log-locality branch March 26, 2021 22:45
@ghost ghost locked as resolved and limited conversation to collaborators Apr 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants