Skip to content
This repository has been archived by the owner on Nov 1, 2023. It is now read-only.

Use custom serialization for block coverage #765

Merged
merged 8 commits into from
Apr 2, 2021
Merged

Use custom serialization for block coverage #765

merged 8 commits into from
Apr 2, 2021

Conversation

ranweiler
Copy link
Member

Update command block coverage serialization to support a more compact JSON format. See tests for examples.

@ranweiler ranweiler requested a review from lzybkr April 1, 2021 22:47
@bmc-msft bmc-msft self-requested a review April 2, 2021 13:40
@ranweiler ranweiler merged commit 9c1540a into microsoft:main Apr 2, 2021
@ranweiler ranweiler deleted the cov-serde branch April 2, 2021 18:59
@ranweiler ranweiler mentioned this pull request Apr 15, 2021
Merged
ranweiler added a commit that referenced this pull request Apr 16, 2021
@ranweiler
Use u32 to represent module offsets (#811)
404c123 
In #765, we introduced an assumption that all module-relative instruction offsets are representable by a `u32`. Move to an explicit `u32` repr for offsets, and add validation to check for overflow at conversion sites.
@ghost ghost locked as resolved and limited conversation to collaborators May 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bmc-msft bmc-msft bmc-msft approved these changes

@lzybkr lzybkr lzybkr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ranweiler @lzybkr @bmc-msft