Skip to content
This repository has been archived by the owner on Nov 1, 2023. It is now read-only.

mark task as failued if ADO notification fails #77

Merged
merged 2 commits into from
Oct 2, 2020
Merged

mark task as failued if ADO notification fails #77

merged 2 commits into from
Oct 2, 2020

Conversation

bmc-msft
Copy link
Contributor

@bmc-msft bmc-msft commented Oct 2, 2020

Summary of the Pull Request

When notifications related to a report fail, the task that generated the report should be marked as failed

PR Checklist

Info on Pull Request

This traps on the python Exceptions related to configuration errors in ADO notifications and marks the task that generated the report as failed.

Validation Steps Performed

Use an invalid ADO notification config (such as invalid username for assign to), generate a report (such as via onefuzz debug notification job) and observe that the crash reporting job is marked as failed.

@bmc-msft bmc-msft merged commit 8b6ea9f into microsoft:main Oct 2, 2020
@bmc-msft bmc-msft deleted the fail-tasks-on-ado-failure branch October 2, 2020 02:00
@ghost ghost locked as resolved and limited conversation to collaborators Apr 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

On ADO notification failure, the task associated in the report should be marked as failed
3 participants