This repository has been archived by the owner on Nov 1, 2023. It is now read-only.
Improve precision of inline table access scanning #864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ranweiler
commented
May 6, 2021
ranweiler
commented
- Detect Sancov table accesses via static displacements, not just PC-relative
- Explicitly skip instructions with no memory operand
- Skip instructions whose effective address relies on (non-PC) register values
ranweiler
commented
May 6, 2021
| while decoder.can_decode() { | ||
| decoder.decode_out(&mut inst); | ||
|
|
||
| // If no memory operand, there is no table access. |
There was a problem hiding this comment.
In a future cleanup pass, we'll factor out all this detection logic into a standalone function or (configurable) struct.
|
Build failed due to |
bmc-msft
approved these changes
May 7, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.