This repository has been archived by the owner on Nov 1, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 199
Add NoNewWork node command to tell free nodes to stop asking for new work #866
Merged
bmc-msft
merged 7 commits into
microsoft:main
from
bmc-msft:enable-telling-free-nodes-to-stop-asking-for-work
May 7, 2021
Merged
Add NoNewWork node command to tell free nodes to stop asking for new work #866
bmc-msft
merged 7 commits into
microsoft:main
from
bmc-msft:enable-telling-free-nodes-to-stop-asking-for-work
May 7, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note, as is this currently checks is the minimum version 2.16.1, which is the next possible release this could go into. If we make a 2.16.1 that doesn't include this value, we should bump it. |
Manual testing done:
|
ranweiler
changed the title
Add NewNewWork node command to tell free nodes to stop asking for new work
Add NoNewWork node command to tell free nodes to stop asking for new work
May 7, 2021
ranweiler
reviewed
May 7, 2021
ranweiler
approved these changes
May 7, 2021
chkeita
approved these changes
May 7, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, there are two states that are non-obvious as to what happens next.
This PR adds sending "no_new_work" command to Nodes which basically allows us to tell free nodes to stop.
NOTE: The node command infra in the supervisor will fail badly if it receives an unsupported command. As such, this includes "minimum supported version" support that gate sending the message such that we don't accidentally break nodes that are actively doing work.