Fix multi proxy race condition #909
Conversation
|
To compare just the changes for this PR without the changes in #908, use this link: bmc-msft/onefuzz@proxy-state-update-event...fix-multi-proxy-race-condition |
| @@ -34,6 +41,17 @@ def main(mytimer: func.TimerRequest, dashboard: func.Out[str]) -> None: # noqa: | |||
| ) | |||
| process_state_updates(proxy) | |||
|
|
|||
| if proxy.is_outdated(): | |||
| proxy.outdated = True | |||
There was a problem hiding this comment.
In the future, should outdated really be a state, instead of an additional field? So we'd have a ProxyState that would be an extension of VmState.
Co-authored-by: Joe Ranweiler <joe@lemma.co>
|
Hello @bmc-msft! Because this pull request has the Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 18 hours, a condition that will be fulfilled in about 5 hours 56 minutes. No worries though, I will be back when the time is right! 😉 p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit 
ghost
locked as resolved and limited conversation to collaborators
Refactored PR of #904 for easier review. Once #908 is reviewed & merged, this will be easier to review.