Skip to content
This repository has been archived by the owner on Nov 1, 2023. It is now read-only.

add an optional initial delay for heartbeats #937

Merged
4 commits merged into from
Jun 1, 2021

Conversation

bmc-msft
Copy link
Contributor

@bmc-msft bmc-msft commented May 27, 2021

One of the difficulties in crash repro as task is a race condition where we the client tries to connect before the cdb is running.

This makes it such that we can use the heartbeat to identify if the task has started before connecting in.

NOTE: In this PR, it's always set to None. See #830 for it's actual usage. However, I split out the PR for easier review.

@ghost
Copy link

ghost commented Jun 1, 2021

Hello @bmc-msft!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit e766913 into microsoft:main Jun 1, 2021
@bmc-msft bmc-msft deleted the add-heartbeat-initialization-delay branch June 1, 2021 20:09
@ghost ghost locked as resolved and limited conversation to collaborators Jul 2, 2021
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants