This repository has been archived by the owner on Nov 1, 2023. It is now read-only.
fix GithubIssueTemplate deserialization #990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
)" This reverts commit 4472d58.
chkeita
changed the title
chkeita
changed the title
|
ADOTemplate and TeamsTemplate are likely impacted by this issue as well for the same reasons. Is it possible to make this a fix within the SecretData implementation rather than one that needs to be replicated for each implementation? |
I added two tests for I could not put the fix in |
bmc-msft
reviewed
Jun 16, 2021
bmc-msft
reviewed
Jun 16, 2021
bmc-msft
reviewed
Jun 16, 2021
bmc-msft
approved these changes
Jun 17, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert change made in #985
fixed GithubIssueTemplate deserialization