This repository has been archived by the owner on Nov 16, 2023. It is now read-only.
WebGL: Fix potential compilation failure in LeakyRelu op #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fs-eire
reviewed
Mar 14, 2019
| @@ -19,7 +19,7 @@ export class WebGLLeakyRelu extends LeakyRelu implements WebGLOperator { | |||
| uniform sampler2D A; | |||
| void main() { | |||
| float v = texture2D(A, TexCoords).r; | |||
| gl_FragColor = vec4(v < 0.0 ? v * ${this.alpha} : v); | |||
| gl_FragColor = vec4(v < 0.0 ? v * float(${this.alpha}) : v); | |||
There was a problem hiding this comment.
is float() works in compile time or runtime in glsl? if it is the latter then toExponential() is a better option
There was a problem hiding this comment.
I think we can tackle this solution across all the shaders (many shaders need the answer to that investigation)
fs-eire
approved these changes
Mar 15, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.