Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add general regex support #822

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Add general regex support #822

wants to merge 6 commits into from
+573 −297

Conversation

sayanshaw24
Copy link
Contributor

Add RegexMatchGeneral parser designed to handle virtually any regex case.

This implementation also adds support for regex categories (such as "\p{L}") which the C++ Standard Library methods (std::regex) do not support.

@sayanshaw24 sayanshaw24 marked this pull request as ready for review October 15, 2024 21:24
@sayanshaw24 sayanshaw24 requested a review from a team as a code owner October 15, 2024 21:24
wenbingl
wenbingl reviewed Oct 15, 2024
View reviewed changes
Copy link
Member

@wenbingl wenbingl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did compare the perf diff between the original GPT2 implementation and the changes in this PR?

operators/tokenizer/bpe_utils.hpp Outdated Show resolved Hide resolved
operators/tokenizer/bpe_utils.hpp Show resolved Hide resolved
operators/tokenizer/bpe_utils.hpp Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wenbingl wenbingl wenbingl left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sayanshaw24 @wenbingl