Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable large models with generate_artifacts API #20942

Closed
wants to merge 3 commits into from
Closed

Enable large models with generate_artifacts API #20942

wants to merge 3 commits into from

Conversation

carzh
Copy link
Contributor

@carzh carzh commented Jun 5, 2024 •
edited
Loading

Description

Added enable_large_models flag to generate_artifacts API call

Motivation and Context

  • ONNX function calls such as shape_inference and the ONNX checker run into errors when passed a ModelProto > 2GB (issue tracked here)
  • This PR adds the option to disable these API calls in generate_artifacts until the ONNX serialization issue is resolved

@carzh carzh requested review from baijumeswani and skottmckay June 5, 2024 18:47
@carzh carzh mentioned this pull request Jun 6, 2024
Merged
@carzh carzh closed this Jun 6, 2024
@carzh carzh deleted the carzh/optional_shape_inference branch June 6, 2024 23:02
carzh added a commit that referenced this pull request Jun 21, 2024
@carzh
Enable >2GB models + allow model paths to be passed for generate_arti…
6236707 
…facts API (#20958)

### Description
Alternative design from #20942 

Allow users to pass in a model path for the generate_artifacts API. 

### Motivation and Context
- ONNX API calls such as the onnx checker + shape inference fail when
given a model > 2GB, but work if a path to a model >2GB is passed in.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baijumeswani baijumeswani Awaiting requested review from baijumeswani

@skottmckay skottmckay Awaiting requested review from skottmckay

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@carzh