enhance string util functions #21893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fs-eire
force-pushed
the
fs-eire/string
branch
from
10729ec
to
3fa5115
Compare
snnn
previously approved these changes
Aug 28, 2024
|
What's the need for writing a wrapper for ostringstream? ostringstream is already general enough. |
Using a function call for appending to ostream is helpful when using with macros or other template functions.
|
snnn
reviewed
Aug 28, 2024
pranavsharma
approved these changes
Aug 29, 2024
guschmue
approved these changes
Aug 29, 2024
fs-eire
added a commit
that referenced
this pull request
Sep 3, 2024
### Description revert forceinline for MakeString. This change reverts #21893. The forceinline was introduced for performance considerations, however it turns out to have some notable binary size increase, which is a concern for some binary size sensitive platforms like Android. I made a few tests locally and found it is not related to whether or not have used the template struct `if_char_array_make_ptr_t` trick. So I have to revert this back.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
MakeStringforce inlineadd aStringJoinutilityMotivation and Context