Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-Lora support #22046

Merged
merged 94 commits into from
Sep 30, 2024
Merged

Multi-Lora support #22046

merged 94 commits into from
Sep 30, 2024

Conversation

yuslepukhin
Copy link
Member

Description

Motivation and Context

include/onnxruntime/core/session/onnxruntime_c_api.h Outdated Show resolved Hide resolved
include/onnxruntime/core/session/onnxruntime_c_api.h Outdated Show resolved Hide resolved
include/onnxruntime/core/session/onnxruntime_c_api.h Outdated Show resolved Hide resolved
include/onnxruntime/core/session/onnxruntime_cxx_api.h Outdated Show resolved Hide resolved
onnxruntime/python/onnxruntime_pybind_state.cc Outdated Show resolved Hide resolved
onnxruntime/test/lora/lora_test.cc Outdated Show resolved Hide resolved
onnxruntime/test/shared_lib/test_inference.cc Outdated Show resolved Hide resolved
onnxruntime/test/shared_lib/test_inference.cc Outdated Show resolved Hide resolved
baijumeswani
baijumeswani previously approved these changes Sep 30, 2024
@yuslepukhin yuslepukhin merged commit d9de054 into main Sep 30, 2024
80 of 82 checks passed
@yuslepukhin yuslepukhin deleted the yuslepukhin/multi_lora branch September 30, 2024 22:59
@ranjitshs
Copy link
Contributor

@snnn @yuslepukhin
I see some tests failures in AIX. I will debug and raise PR if I find any fix.

4: [ RUN      ] CApiTest.RunWithLoraAdapterFromFile
4: unknown file: Failure
4: C++ exception with description "/home/buildusr/jenkins/workspace/onnxruntime-openxl/onnxruntime/onnxruntime/core/common/safeint.h:17 static void SafeIntExceptionHandler<onnxruntime::OnnxRuntimeException>::SafeIntOnOverflow() Integer overflow
4: " thrown in the test body.
4: 
4: [  FAILED  ] CApiTest.RunWithLoraAdapterFromFile (0 ms)
4: [ RUN      ] CApiTest.RunWithLoraAdapterFromArray
4: unknown file: Failure
4: C++ exception with description "/home/buildusr/jenkins/workspace/onnxruntime-openxl/onnxruntime/onnxruntime/core/common/safeint.h:17 static void SafeIntExceptionHandler<onnxruntime::OnnxRuntimeException>::SafeIntOnOverflow() Integer overflow
4: " thrown in the test body.
4: 
4: [  FAILED  ] CApiTest.RunWithLoraAdapterFromArray (0 ms)
4: [ RUN      ] CApiTest.RunBaseLoraModel

@snnn
Copy link
Member

snnn commented Oct 1, 2024

@yuslepukhin , and there is a compile error on Android ARM32:

/onnxruntime_src/onnxruntime/test/shared_lib/test_inference.cc:4460:31: error: implicit conversion loses integer precision: 'streamoff' (aka 'long long') to 'const size_t' (aka 'const unsigned int') [-Werror,-Wshorten-64-to-32]
 4460 |   const size_t adapter_size = adapter_file.tellg();

yuslepukhin added a commit that referenced this pull request Oct 1, 2024
### Description
<!-- Describe your changes. -->

### Motivation and Context
Build issue
#22046 (comment)
yuslepukhin added a commit that referenced this pull request Oct 1, 2024
### Description
Java parts of Multi-LoRA support - #22046.

### Motivation and Context
API equivalence with Python & C#.

---------

Co-authored-by: Dmitri Smirnov <dmitrism@microsoft.com>
yuslepukhin added a commit that referenced this pull request Oct 2, 2024
### Description


### Motivation and Context
#22046
snnn added a commit that referenced this pull request Oct 4, 2024
### Description

A left-over of PR #22046 

### Motivation and Context
Right now our VCPKG pipelines are broken.
yuslepukhin added a commit that referenced this pull request Oct 4, 2024
### Description
Address comments


### Motivation and Context
Re: #22046
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants