update build configurations to webgpu EP #22047
Conversation
Fix Release build errors. Fix Android build errors.
…ay/MiscWebGPUUpdates
|
merged a few misc improvements and only list build configuration change. |
…ay/MiscWebGPUUpdates
…rosoft/onnxruntime into skottmckay/MiscWebGPUUpdates
…catalyst Add additional required frameworks
|
Sorry - I didn't realize this branch was in a PR and I just merged in origin/main. @fs-eire do you want to update your branch with the latest origin/main to make the diffs reasonable again? |
I did it just now. But seems the status of PR is not updating to remove those unrelated changes. |
|
You need to close this one and open a new PR. |
I tried to do that but in the change preview it still shows 140 files. Maybe need a git merge |
…ay/MiscWebGPUUpdates
OK much better now. |
| @@ -435,7 +435,7 @@ std::unique_ptr<KernelRegistry> RegisterKernels() { | |||
| KERNEL_CREATE_INFO(9, Cosh), | |||
| KERNEL_CREATE_INFO(9, Asinh), | |||
| KERNEL_CREATE_INFO(9, Acosh), | |||
| KERNEL_CREATE_INFO(9, Atanh), | |||
| // KERNEL_CREATE_INFO(9, Atanh), TEMPORARY - Doesn't handle 1.0f -> inf with Metal | |||
There was a problem hiding this comment.
how do we want to deal with Atanh on macOS/iOS? add a #ifdef for apple?
There was a problem hiding this comment.
If there any way to do it gracefully in the shader?
There was a problem hiding this comment.
what I can think is using #ifdef APPLE together with shader string generation.
for non-apple: just use builtin atanh
for apple: use custom_atanh:
fn custom_atanh(a) {
if (a == 1.0f) {
...
}
return atanh(a);
}
There was a problem hiding this comment.
Not sure it's possible.
https://www.w3.org/TR/WGSL/#differences-from-ieee754
A shader-creation error results if any const-expression of floating-point type overflows or evaluates to NaN or infinity.
We'd need to return +infinity, but it sounds like that's not possible.
Description
list out for tracking.