Jar Maven Signing - GnuPG and sha256 #22217
Open
+152
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snnn
reviewed
Sep 25, 2024
| workingDirectory: '$(Build.BinariesDirectory)' | ||
| script: | | ||
| #!/bin/bash | ||
|
|
There was a problem hiding this comment.
Add
set -x
to the beginning of the script. Otherwise if any of the command failed we wouldn't know.
snnn
reviewed
Sep 25, 2024
| inputs: | ||
| targetType: 'inline' | ||
| workingDirectory: '$(Build.BinariesDirectory)' | ||
| script: | |
There was a problem hiding this comment.
If you move the content to a separate *.ps1 file, we have a pipeline that can do grammar check and static analysis on the file.
snnn
reviewed
Sep 25, 2024
| foreach ($file in $targeting_original_files) { | ||
| $file_path = Join-Path $jar_file_directory -ChildPath $file | ||
| Write-Host "GnuPG signing to file: "$file_path | ||
| & $gpg_exe_path --pinentry-mode loopback --passphrase-file $passphrase_file -ab $file_path |
There was a problem hiding this comment.
For all such external commands, you need to check their exit code. Like:
if ($lastExitCode -ne 0) {
Write-Host -Object "xxx command failed. Exitcode: $exitCode"
exit $lastExitCode
}
See https://github.com/microsoft/onnxruntime/blob/main/tools/ci_build/github/windows/helpers.ps1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Jar maven signing:
Jar packages artifacts:
Motivation and Context
Previously, it is manually signed.
Goal: make it automatically.