Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TensorRT EP] revert oss parser to 10.7-GA #23710

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

[TensorRT EP] revert oss parser to 10.7-GA #23710

wants to merge 9 commits into from

Conversation

yf711
Copy link
Contributor

@yf711 yf711 commented Feb 14, 2025

Description

  • Revert as oss parser version 10.8-GA rely on onnx 1.18, which is not available yet.
  • add TENSORRT_PYTHON_INCLUDE_DIR when oss parser>=10.6
  • add check_trt_version() in cmake config to check if version meets requirement

Motivation and Context

  • OSS 10.8-GA can't work with ONNX 1.17, which will cause ORT build failure when enabling --use_tensorrt_oss_parser
  • Action needed to adapt latest oss parser branch to fix scatterND attribute issue

@yf711 yf711 requested a review from chilo-ms February 14, 2025 23:14
@chilo-ms
Copy link
Contributor

The TRT CI has building issue.

@yf711
Copy link
Contributor Author

yf711 commented Feb 18, 2025

onnx-tensorrt introduced a dependency plugin.h, which is available by tarball/zip installation (underTensorRT-tarball/python/include/impl/) but not available by linux package installation. OSS parser users who use Windows/Linux tarball installation are not affected.
Updating the logic to make sure builtin parser users are not blocked

@jywu-msft
Copy link
Member

this is a bit confusing. if we publish packages built against TRT 10.8 but stay with10.7 parser?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants