Change CMAKE_CUDA_STANDARD to C++17 for Windows GPU build #7883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pranavsharma
reviewed
Jun 1, 2021
| @@ -18,8 +18,8 @@ constexpr const char* UpsampleModeCubic = "cubic"; | |||
| // is a 4x4 matrix | |||
| const size_t CubicModeGridLength = 4; | |||
|
|
|||
| using GetNearestPixelFunc = std::function<int64_t(float, bool)>; | |||
| using GetOriginalCoordinateFunc = std::function<float(float, float, float, float, float, float)>; | |||
| using GetNearestPixelFunc = int64_t(*)(float, bool); | |||
There was a problem hiding this comment.
Is this change required for c++17?
There was a problem hiding this comment.
Yes, otherwise it doesn't build.
pranavsharma
approved these changes
Jun 2, 2021
7 tasks
harshithapv
pushed a commit
that referenced
this pull request
Jun 15, 2021
harshithapv
added a commit
that referenced
this pull request
Jun 15, 2021
* bump ORT version to 1.8.1 * Change CMAKE_CUDA_STANDARD to C++17 for Windows GPU build (#7883) Co-authored-by: Changming Sun <chasun@microsoft.com>
snnn
added a commit
that referenced
this pull request
Jun 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Otherwise it doesn't compile with the latest Visual Studio. Anyway, we will move to C++17 soon, so this change doesn't hurt.
Motivation and Context