Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug regression in experimental value info export #1341

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

BowenBao
Copy link
Contributor

@BowenBao BowenBao commented Apr 3, 2024

Stack from ghstack (oldest at bottom):

Previous fix didn't export subgraph value info.

BowenBao added a commit that referenced this pull request Apr 3, 2024
ghstack-source-id: 7f6f4d4bd5600e2232c49a8b247520274548b51e
Pull Request resolved: #1341
@BowenBao BowenBao requested a review from justinchuby April 3, 2024 01:24
@BowenBao BowenBao changed the base branch from gh/BowenBao/29/base to main April 3, 2024 01:25
Copy link

codecov bot commented Apr 3, 2024

Codecov Report

Attention: Patch coverage is 86.66667% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 76.03%. Comparing base (e87e05d) to head (ffca06e).

Files Patch % Lines
...ipt/function_libs/torch_lib/graph_building_test.py 85.18% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1341      +/-   ##
==========================================
+ Coverage   75.95%   76.03%   +0.07%     
==========================================
  Files         134      134              
  Lines       17773    17777       +4     
  Branches     2927     2933       +6     
==========================================
+ Hits        13500    13517      +17     
+ Misses       3827     3815      -12     
+ Partials      446      445       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Apr 3, 2024

Test Results

     24 files  ±     0      24 suites  ±0   1h 42m 29s ⏱️ - 8m 38s
 12 984 tests + 1 243   9 294 ✅ +  867    3 688 💤 +   376  2 ❌ ±0 
259 109 runs   - 16 907  59 051 ✅  - 4 226  200 056 💤  - 12 681  2 ❌ ±0 

For more details on these failures, see this check.

Results for commit ffca06e. ± Comparison against base commit e87e05d.

@BowenBao BowenBao merged commit e0524fc into main Apr 3, 2024
31 of 35 checks passed
@BowenBao BowenBao deleted the gh/BowenBao/29/head branch April 3, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants