-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor builder out as an utility #1772
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1772 +/- ##
==========================================
- Coverage 75.08% 75.08% -0.01%
==========================================
Files 245 245
Lines 26509 26507 -2
Branches 4831 4830 -1
==========================================
- Hits 19904 19902 -2
Misses 5675 5675
Partials 930 930 ☔ View full report in Codecov by Sentry. |
Test Results 24 files ± 0 24 suites ±0 3h 32m 32s ⏱️ + 13m 28s For more details on these failures and errors, see this check. Results for commit 4f1e85c. ± Comparison against base commit 35a35db. This pull request removes 993 and adds 1457 tests. Note that renamed tests count towards both.
This pull request removes 223 skipped tests and adds 1 skipped test. Note that renamed tests count towards both.
This pull request skips 43 and un-skips 1 tests.
♻️ This comment has been updated with latest results. |
All sounds good! |
Move the IR builder utility out as a separate utility.
TODO:
ir
folder?Builder
be merged with theTape
class?