-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IR] Implement methods to check dynamism on Shape #1952
Conversation
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #1952 +/- ##
==========================================
+ Coverage 74.89% 74.97% +0.08%
==========================================
Files 262 262
Lines 28467 28558 +91
Branches 3284 3289 +5
==========================================
+ Hits 21320 21411 +91
- Misses 6138 6139 +1
+ Partials 1009 1008 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think a method return whether the Shape is static or not would be another useful method? (When users do not want to go through all dims one by one.)
Sure! Basically we can make |
Done |
Define
is_static()
andis_dynamic()
on Shape. Users can check if the shape is static/dynamic, or if a specific axis is static/dynamic.Fixes #1950