Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump pylint from 2.17.6 to 3.3.3 in /requirements/lintrunner #1990

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions onnxscript/converter.py
Original file line number Diff line number Diff line change
Expand Up @@ -800,6 +800,9 @@ def translate_slice(slice_expr: ast.Slice) -> tuple[str, str, str]:
non_scalar_indices.extend(scalar_indices)
if non_scalar_indices:
last_axis, _ = non_scalar_indices[-1]
else:
# TODO(justinchuby): Clarify what last_axis should be when non_scalar_indices is False
last_axis = None
for axis, index_expr in non_scalar_indices:
index_value = self._translate_expr(index_expr)
axis_attr = self._make_onnx_attr("axis", axis)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -832,7 +832,7 @@ def _override_with_symbolic_value_info_proto(self, onnx_model: onnx.ModelProto):
existing_value_info = {info.name: info for info in onnx_model.graph.value_info}

# Override value_info for top level graph inputs.
for input in self.torch_graph.inputs():
for input in self.torch_graph.inputs(): # pylint: disable=not-an-iterable
if input not in self._value_to_tensor:
raise RuntimeError(f"Input '{input.debugName()}' has no type.")
tensor = self._value_to_tensor[input]
Expand All @@ -847,7 +847,7 @@ def _override_with_symbolic_value_info_proto(self, onnx_model: onnx.ModelProto):
break

# Override value_info for top level graph outputs.
for output in self.torch_graph.outputs():
for output in self.torch_graph.outputs(): # pylint: disable=not-an-iterable
if output not in self._value_to_tensor:
raise RuntimeError(f"Output '{output.debugName()}' has no type.")
tensor = self._value_to_tensor[output]
Expand Down
1 change: 1 addition & 0 deletions pyproject_pylint.toml
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ disable = [
"too-many-instance-attributes",
"too-many-lines",
"too-many-locals",
"too-many-positional-arguments",
"too-many-public-methods",
"too-many-return-statements",
"too-many-statements", # TODO: we should work on these: too-many-xxx series
Expand Down
2 changes: 1 addition & 1 deletion requirements/lintrunner/requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,6 @@ ruff==0.8.6
mypy==1.10.1
types-PyYAML==6.0.12.20241230
# PYLINT
pylint==2.17.6
pylint==3.3.3
# EDITORCONFIG-CHECKER
editorconfig-checker==3.0.3
Loading