Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update typing_extensions requirement #2002

Merged

Conversation

Johansmm
Copy link
Contributor

@Johansmm Johansmm commented Jan 8, 2025

'TypeIs' is available from typing_extensions v4.10.
Close #1996

'TypeIs' is available from typing_extensions v4.10
Copy link
Collaborator

@justinchuby justinchuby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@justinchuby justinchuby enabled auto-merge (squash) January 8, 2025 19:52
Copy link

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.44%. Comparing base (5e7b0e4) to head (3606d70).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2002   +/-   ##
=======================================
  Coverage   74.44%   74.44%           
=======================================
  Files         217      217           
  Lines       28247    28247           
  Branches     3367     3367           
=======================================
  Hits        21028    21028           
  Misses       6140     6140           
  Partials     1079     1079           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@justinchuby justinchuby merged commit 646116c into microsoft:main Jan 8, 2025
23 of 29 checks passed
@Johansmm Johansmm deleted the update-typing-extensions-version branch January 8, 2025 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

ONNXscript does not work with typing_extensions < 4.10
2 participants