Skip to content
This repository has been archived by the owner on Nov 16, 2023. It is now read-only.

Simplify marketplace deploy config #209

Closed
5 tasks done
yiyione opened this issue Feb 3, 2021 · 1 comment
Closed
5 tasks done

Simplify marketplace deploy config #209

yiyione opened this issue Feb 3, 2021 · 1 comment
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@yiyione
Copy link
Contributor

yiyione commented Feb 3, 2021

Introduction

Simplify marketplace deploy config.

Motivations

Currently deploy marketplace need to change to many config.
It's difficult for the admin to deploy marketplace.

Proposals

Admin only need to set cluster.common.marketplace = "true", will be able to deploy the marketplace.
If need more detail, can add some advance config manually.

  1. Admin can deploy marketplace in PAI quick start script (set enable_marketplace: true in config.yaml)
  2. Only need to set cluster.common.marketplace = "true" to enable Marketplace
  3. Auto add marketplace to webportal-plugins if set cluster.common.marketplace = "true"

Work Plan

#201 PR

Demo

Test cases

  • 1. Test quick-start script
    1. Set enable_marketplace: true in config.yaml of the quick-start config
    2. Deploy OpenPAI by quick-start script.
    3. Should deploy marketplace automatically.
    4. Should auto add marketplace to webportal plugin.
    5. Should show Welcome to marketplace! when visiting <host>/marketplace/api/
  • 2. Test close marketplace
    1. Stop marketplace-db, marketplace-restserver, marketplace-webportal, webportal, pylon service in paictl.
    2. Set cluster.common.marketplace: "false" and update config (push to cluster)
    3. Start marketplace-db, marketplace-restserver, marketplace-webportal, webportal, pylon service in paictl.
    4. Should not should marketplace in webportal plugin
    5. Should not should Welcome to marketplace! when visiting <host-ip>/marketplace/api/
  • 3. Test reopen marketplace
    1. Stop marketplace-db, marketplace-restserver, marketplace-webportal, webportal, pylon service in paictl.
    2. Set cluster.common.marketplace: "true" and update config (push to cluster)
    3. Start marketplace-db, marketplace-restserver, marketplace-webportal, webportal, pylon service in paictl.
    4. Should marketplace in webportal plugin
    5. Should Welcome to marketplace! when visiting <host-ip>/marketplace/api/
  • 4. Test close auto-added marketplace to webportal plugin
    1. Stop webportal service in paictl
    2. Set webportal.marketplace: false and update config (push to cluster)
    3. Start webportal service in paictl
    4. Should not show marketplace in webportal plugin
  • 5. Test auto use https
    1. Stop marketplace-db, marketplace-restserver, marketplace-webportal, webportal, pylon service in paictl.
    2. Setup https in PAI
    3. Start marketplace-db, marketplace-restserver, marketplace-webportal, webportal, pylon service in paictl.
    4. Should use https://host/marketplace/plugin.js in webportal plugin (Press F12 to check the network)
    5. Should call https://host/marketplace/api/ in marketplace-webportal page (Press F12 to check the network)
@yiyione yiyione added the enhancement New feature or request label Feb 3, 2021
@yiyione yiyione mentioned this issue Feb 4, 2021
40 tasks
@qfyin qfyin added this to the 2021Feb milestone Feb 9, 2021
@qfyin
Copy link
Contributor

qfyin commented Feb 9, 2021

PR microsoft/pai#5283 merged in PAI repo

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants