This repository has been archived by the owner on Jun 6, 2024. It is now read-only.
[Marketplace] Simplify marketplace setting #5283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… auto use config from their prerequisite services
5 tasks
hzy46
reviewed
Feb 3, 2021
| @@ -91,7 +91,24 @@ spec: | |||
| - name: WEBPORTAL_PLUGINS | |||
| # A raw JSON formatted value is required here. | |||
| value: | | |||
| {{ cluster_cfg['webportal']['plugins'] }} | |||
| [ | |||
| {% if cluster_cfg['cluster']['common']['marketplace'] == "true" %} | |||
There was a problem hiding this comment.
What if:
1. The admin deploys marketplace in a previous version of PAI
2. He upgrades PAI to `v1.6.0`
Will there be two duplicate marketplace entries here?
There was a problem hiding this comment.
Yes, if the old webportal-plugin still in services-configurations.yaml, there will be two duplicate marketplace entries here.
There was a problem hiding this comment.
I add an optional config to disable the auto-added marketplace-plugin in webportal.
The admin can avoid the duplicate marketplace entries by it.
hzy46
reviewed
Feb 3, 2021
| @@ -7,6 +7,7 @@ cluster: | |||
| data-path: "/datastorage" | |||
| qos-switch: "{{ env["cfg"]["qos-switch"] | default('false') }}" | |||
| docker-data-root: "{{ env['cfg']['docker_data_root'] | default('/mnt/docker') }}" | |||
| marketplace: "true" | |||
There was a problem hiding this comment.
Maybe marketplace: "false"?
Or we can turn on marketplace by default, but notify all PAI devs in advance.
There was a problem hiding this comment.
Done, set to "false" by default, and add enable_marketplace: false to config.yaml.
hzy46
approved these changes
Feb 4, 2021
debuggy
approved these changes
Feb 4, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cluster.common.marketplace = "true"cluster.common.marketplace = "true"Related issue & test cases: microsoft/openpaimarketplace#209 (comment)