This repository has been archived by the owner on Jun 6, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 549
[Marketplace] Simplify marketplace setting #5283
Merged
yiyione
merged 11 commits into
master
from
yiyi/marketplace/simplify_marketplace_setting
Feb 5, 2021
Merged
Changes from 8 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
4403806
add prerequisite in marketplace-webportal and marketplace-restserver,…
yiyione 46f1b5f
Fix template
yiyione 7c17865
Fix template
yiyione 1948fad
Fix template
yiyione b02f37e
auto use https in marketplace if pylon.ssl
yiyione c16378c
auto use https in marketplace if pylon.ssl
yiyione aca4b11
Add deploy marketplace to quickstart
yiyione f219259
fix template
yiyione de4cd93
Add config to enable/disable the auto-added marketplace-plugin
yiyione 9093cb6
Set marketplace: false in quick-start default services-configuration
yiyione 80b86dc
Add enable_marketplace option to config.yaml
yiyione File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -91,7 +91,24 @@ spec: | |
- name: WEBPORTAL_PLUGINS | ||
# A raw JSON formatted value is required here. | ||
value: | | ||
{{ cluster_cfg['webportal']['plugins'] }} | ||
[ | ||
{% if cluster_cfg['cluster']['common']['marketplace'] == "true" %} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What if:
Will there be two duplicate marketplace entries here? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, if the old webportal-plugin still in services-configurations.yaml, there will be two duplicate marketplace entries here. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I add an optional config to disable the auto-added marketplace-plugin in webportal. |
||
{ | ||
"id": "marketplace", | ||
"title": "Marketplace", | ||
{% if "ssl" in cluster_cfg["pylon"] and cluster_cfg["pylon"]["ssl"] %} | ||
"uri": "{{ cluster_cfg['pylon']['uri-https']}}/marketplace/plugin.js" | ||
{% else %} | ||
"uri": "{{ cluster_cfg['pylon']['uri']}}/marketplace/plugin.js" | ||
{% endif %} | ||
}, | ||
{% endif %} | ||
{% if cluster_cfg['webportal']['plugins']|length > 0 %} | ||
{% for item in cluster_cfg['webportal']['plugins'] %} | ||
{{item}}, | ||
{% endfor %} | ||
{% endif %} | ||
] | ||
ports: | ||
- name: webportal | ||
containerPort: 8080 | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe
marketplace: "false"
?Or we can turn on marketplace by default, but notify all PAI devs in advance.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done, set to "false" by default, and add
enable_marketplace: false
to config.yaml.