[VS Code] Fix add cluster bug when connection timeout (#3929)

* add try catch to json parse error message * add some description for cluster config
microsoft · Dec 2, 2019 · 3102160 · 3102160
1 parent c5ac48e
commit 3102160
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 6 deletions.
diff --git a/schemas/pai_cluster.schema.json b/schemas/pai_cluster.schema.json
@@ -12,12 +12,12 @@
         },
         "password": {
             "type": "string",
-            "description": "PAI cluster password",
+            "description": "PAI cluster password, please keep it empty if use token",
             "minLength": 1
         },
         "token": {
             "type": "string",
-            "description": "PAI cluster access token",
+            "description": "PAI cluster access token, please keep it empty if use password",
             "minLength": 1
         },
         "rest_server_uri": {

diff --git a/src/pai/clusterManager.ts b/src/pai/clusterManager.ts
@@ -256,10 +256,14 @@ export class ClusterManager extends Singleton {
             }));
             cluster.protocol_version = '2';
         } catch (exception) {
-            const error: any = JSON.parse(exception.error);
-            if (error.code === 'NoApiError') {
-                cluster.protocol_version = '1';
-            } else {
+            try {
+                const error: any = JSON.parse(exception.error);
+                if (error.code === 'NoApiError') {
+                    cluster.protocol_version = '1';
+                } else {
+                    cluster.protocol_version = '2';
+                }
+            } catch (err) {
                 cluster.protocol_version = '2';
             }
         }