Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 3.7.4 to publish vcpkg port #86

Closed
bhardwajs opened this issue Mar 31, 2022 · 2 comments
Closed

Release 3.7.4 to publish vcpkg port #86

bhardwajs opened this issue Mar 31, 2022 · 2 comments

Comments

@bhardwajs
Copy link
Contributor

Following up on #79, to publish a vcpkg port, we need a version number (https://github.com/microsoft/vcpkg/blob/master/docs/maintainers/manifest-files.md). Would it be possible to cut a new release (3.7.4) so that a vcpkg port can be published?

I can send a PR to update the version string in CMakeLists.txt.
bhardwajs added a commit to bhardwajs/pict that referenced this issue Mar 31, 2022
@bhardwajs
Update version to 3.7.4 in CMakeLists.txt
e123250 
Updating version to 3.7.4 so we can cut a new release.

Needed for microsoft#86
@bhardwajs bhardwajs mentioned this issue Mar 31, 2022
Merged
@jaccz
Copy link
Member

jaccz commented Mar 31, 2022

I can publish a new ver. Would you make the changes?
In addition to cmakelists.txt, we'll need to make a change in /cli/ver.h.
Or maybe there's a way for cmakelists to key off of that file (I doubt it but maybe?)

--Jacek

jaccz pushed a commit that referenced this issue Mar 31, 2022
@bhardwajs
Update version to 3.7.4 in CMakeLists.txt (#87)
84a0196 
Updating version to 3.7.4 so we can cut a new release.

Needed for #86
@jaccz
Copy link
Member

jaccz commented Mar 31, 2022

Good to go?
https://github.com/microsoft/pict/releases/tag/v3.7.4

@jaccz jaccz closed this as completed Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bhardwajs @jaccz