Timeout middleware #120
Merged
Timeout middleware #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmcfarland
commented
Sep 21, 2022
mmcfarland
commented
Sep 21, 2022
mmcfarland
commented
Sep 21, 2022
|
cc @lossyrob for review. |
lossyrob
reviewed
Sep 21, 2022
lossyrob
approved these changes
Sep 21, 2022
This middleware is intended to return a controlled message and error to the user in cases where the request exceeds the timeout. Previously, they might recieve a QueryCancelledError, a Service Unavailable, or a GatewayTimeout depending on which mechanism (still sometimes opaque to us) initiated the timeout. By ensuring the setting is less than the gateway timeout, we should collect logs in all instances and provide a meaningful error message to the user. # Please enter the commit message for your changes.
mmcfarland
force-pushed
the
feature/timeout-debugging
branch
from
97b2108 to
22a5d88
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This middleware is intended to return a controlled message and error to
the user in cases where the request exceeds a service-configurable timeout. Previously,
they might receive a QueryCancelledError, a Service Unavailable, or a
GatewayTimeout depending on which mechanism (still sometimes opaque to
us) initiated the timeout. By ensuring the setting is less than the
gateway timeout, we should collect logs in all instances and provide a
meaningful error message to the user.
Implementation was inspired by discussion on this issue.
Also filters out the health check pings from the console logs.