Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stac-api-validator #148

Merged
merged 2 commits into from
Jan 31, 2023
Merged

Conversation

gadomski
Copy link
Contributor

Description

Adds stac-api-validator to CI. Doesn't include features and item-search validation, but includes comments in the validation script saying why.

IMO this could be a good check to make sure updates are still producing valid STAC API, but is potentially risky because stac-api-validator is still under pretty active development. I've pinned the version to a known good-enough version to help guard againt unexpected regressions that aren't our fault.

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

I've run the validation script locally.

Checklist:

  • I have performed a self-review
  • Code is linted and styled (./scripts/format)

Doesn't include features and item-search validation, but includes comments in
the validation script saying why.
@mmcfarland
Copy link
Member

Looks good, thanks! Will keep an eye out for flake, per your comment, but is a good addition.

@mmcfarland mmcfarland merged commit 95190c5 into microsoft:main Jan 31, 2023
@gadomski gadomski deleted the stac-api-validator branch April 3, 2023 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants