Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement queryables through proxy to online json files #44

Merged
merged 9 commits into from
Feb 8, 2022

Conversation

moradology
Copy link
Contributor

@moradology moradology commented Feb 1, 2022

Description

This PR adds support for per-collection queryables which will, for now, be proxied from https://planetarycomputer.microsoft.com/stac/{collection}/queryables.json.

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Tests have been added to check for 200 status. Both /queryables and /collections/naip/queryables appear to be correctly constructed json schemas.

Checklist:

Please delete options that are not relevant.

  • I have performed a self-review
  • Changelog has been updated
  • Unit tests pass locally (./scripts/test)
  • Code is linted and styled (./scripts/format)

@moradology moradology marked this pull request as ready for review February 2, 2022 19:32
@moradology moradology requested a review from mmcfarland February 2, 2022 19:32
pcstac/pcstac/filter.py Show resolved Hide resolved
pcstac/pcstac/filter.py Outdated Show resolved Hide resolved
pcstac/pcstac/filter.py Outdated Show resolved Hide resolved
Copy link
Member

@mmcfarland mmcfarland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@mmcfarland mmcfarland merged commit b50fb42 into microsoft:main Feb 8, 2022
@moradology moradology deleted the feature/queryable-support branch February 8, 2022 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants