update titiler-pgstac version and forward Request in reader
#91
Conversation
| @@ -49,6 +67,10 @@ class MosaicSTACReader(pgstac_mosaic.CustomSTACReader): | |||
|
|
|||
| reader: Type[BaseReader] = attr.ib(default=CustomCOGReader) | |||
|
|
|||
| # We make request an optional attribute to avoid re-writing | |||
| # the whole list of attribute | |||
| request: Optional[Request] = attr.ib(default=None) | |||
There was a problem hiding this comment.
With request now optionally on MosaicSTACReader, I expected to be able to access self.reader.request within methods of PGSTACBackend (like assets_for_tiles), but I get the error
AttributeError: type object 'MosaicSTACReader' has no attribute 'request'
The type annotations suggest this is possible, is that the expected usage? I can confirm that ReaderParams was initialized with a request correctly.
There was a problem hiding this comment.
can you share some code, I have hard to to follow 😓
There was a problem hiding this comment.
Sure, sorry! One use case for having the request available is to use it for our logging within backend/reader methods, e.g., grabbing a trace id from the header so all logs can be associated with a single request. Usage would be like this: f461009, but it doesn't seem like request is available from there.
There was a problem hiding this comment.
latest commit should add self.request (in the Backend)
This PR does:
Requestin readers attribute and use titilerreader_dependencyto inject the Request object in the reader at request time