New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tracing): Properly log Clock calls #1727

Merged

agg23 merged 3 commits into microsoft:main from agg23:clock-tracing-fix

Jan 16, 2025

+86 −15

Contributor

agg23 commented Jan 15, 2025

Due to the lack of the proper wrapping calls, all Clock APIs were not being logged into the recorded trace.

Trace entries are now properly created
Clock entries are named Clock.* matching JS, rather than the previously existing BrowserContext.clock*

agg23 added 3 commits

January 15, 2025 11:47


          Properly mark clock API calls as non-internal, and thus traceable

fb9ae4f


          Rename Clock apiName to match the same style as in JS

fdf73be


          Generic tracing test covering fixed Clock calls

3a89e00

agg23 requested a review from yury-s

January 15, 2025 20:29

yury-s approved these changes

View reviewed changes

agg23 merged commit eb8cf62 into microsoft:main

14 of 19 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet