added a test

microsoft · Mar 17, 2021 · 07d19cf · 07d19cf
1 parent c9287f8
commit 07d19cf
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/playwright/_impl/_helper.py b/playwright/_impl/_helper.py
@@ -203,7 +203,7 @@ def is_safe_close_error(error: Exception) -> bool:
 
 
 def not_installed_error(message: str) -> Exception:
-    return Exception(
+    return Error(
         f"""
 ================================================================================
 {message}

diff --git a/tests/async/test_launcher.py b/tests/async/test_launcher.py
@@ -121,3 +121,12 @@ async def test_browser_close_should_be_callable_twice(browser_type, launch_argum
         browser.close(),
     )
     await browser.close()
+
+
+async def test_browser_launch_non_existing_executable_path_shows_install_msg(
+    browser_type,
+    tmpdir,
+):
+    with pytest.raises(Error) as exc_info:
+        await browser_type.launch(executable_path=tmpdir.join("executable"))
+    assert "python -m playwright install" in exc_info.value.message