Skip to content

Commit

Permalink
test: enable skipped tests (#573)
Browse files Browse the repository at this point in the history
  • Loading branch information
mxschmitt authored Mar 18, 2021
1 parent 47f1a64 commit ba70605
Showing 4 changed files with 0 additions and 12 deletions.
2 changes: 0 additions & 2 deletions playwright/__main__.py
Original file line number Diff line number Diff line change
@@ -22,8 +22,6 @@
def main() -> None:
driver_executable = compute_driver_executable()
my_env = os.environ.copy()
# VSCode's JavaScript Debug Terminal provides it but driver/pkg does not support it
my_env.pop("NODE_OPTIONS", None)
my_env["PW_CLI_TARGET_LANG"] = "python"
subprocess.run([str(driver_executable), *sys.argv[1:]], env=my_env)

5 changes: 0 additions & 5 deletions playwright/_impl/_transport.py
Original file line number Diff line number Diff line change
@@ -53,14 +53,9 @@ async def run(self) -> None:
self._loop = asyncio.get_running_loop()
self._stopped_future: asyncio.Future = asyncio.Future()

driver_env = os.environ.copy()
# VSCode's JavaScript Debug Terminal provides it but driver/pkg does not support it
driver_env.pop("NODE_OPTIONS", None)

proc = await asyncio.create_subprocess_exec(
str(self._driver_executable),
"run-driver",
env=driver_env,
stdin=asyncio.subprocess.PIPE,
stdout=asyncio.subprocess.PIPE,
stderr=_get_stderr_fileno(),
4 changes: 0 additions & 4 deletions tests/async/test_launcher.py
Original file line number Diff line number Diff line change
@@ -41,7 +41,6 @@ async def test_browser_type_launch_should_throw_if_page_argument_is_passed(
assert "can not specify page" in exc.value.message


@pytest.mark.skip("currently disabled on upstream")
async def test_browser_type_launch_should_reject_if_launched_browser_fails_immediately(
browser_type, launch_arguments, assetdir
):
@@ -52,9 +51,6 @@ async def test_browser_type_launch_should_reject_if_launched_browser_fails_immed
)


@pytest.mark.skip(
"does not return the expected error"
) # TODO: hangs currently on the bots
async def test_browser_type_launch_should_reject_if_executable_path_is_invalid(
browser_type, launch_arguments
):
1 change: 0 additions & 1 deletion tests/async/test_page.py
Original file line number Diff line number Diff line change
@@ -313,7 +313,6 @@ async def test_expose_function(page, server):
assert result == 36


@pytest.mark.skip("todo mxschmitt")
async def test_expose_function_should_throw_exception_in_page_context(page, server):
def throw():
raise Exception("WOOF WOOF")

0 comments on commit ba70605

Please sign in to comment.