(🎁) Add | operator on Locators

[KotlinIsland]

umm, based python moment????

[KotlinIsland]

@microsoft-github-policy-service agree

[mxschmitt]

I guess the same makes sense for and? Will discuss with the team later!

[KotlinIsland]

@mxschmitt Do you mean and as in an operator for filter?

[mxschmitt]

(Never mind, Locator.and(...) was something we were experimenting with and I got confused, we didn't ship it)

[mxschmitt]

We decided for now to keep or instead of | since or also provides auto completion support and shows what it is actually doing. Thanks for you suggestion tho!

[KotlinIsland]

Workaround

from playwright.sync_api import Locator

Locator.__or__ = Locator.or_

Unfortunately usages of this will be an error in mypy 😢

[DetachHead]

@mxschmitt it seems silly to not accept this PR when the alternative is to append an underscore to the method name as a workaround for the fact that "or" causes a syntax error.

page.locator('div') | page.locator('span')

looks much less gross than

page.locator('div').or_(page.locator('span'))

python specifically supports this use case, why not take advantage of it?

[mxschmitt]

Feel free to file a feature request for it. We can add it as an alternative syntax, but it requires multiple changes like upstream playwright docs updates, generator updates, and then the actual implementation like in this PR.