Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enhance executable not found check #572

Merged
merged 2 commits into from
Mar 18, 2021
+12 −3
Merged

fix: enhance executable not found check #572

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c9287f8
fix: enhance executable not found check
mxschmitt Mar 17, 2021
07d19cf
added a test
mxschmitt Mar 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions playwright/_impl/_browser_type.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ async def launch(
try:
return from_channel(await self._channel.send("launch", params))
except Exception as e:
if f"{self.name}-" in str(e):
if "because executable doesn't exist" in str(e):
raise not_installed_error(f'"{self.name}" browser was not found.')
raise e

Expand Down Expand Up @@ -124,7 +124,7 @@ async def launch_persistent_context(
context._options = params
return context
except Exception as e:
if f"{self.name}-" in str(e):
if "because executable doesn't exist" in str(e):
raise not_installed_error(f'"{self.name}" browser was not found.')
raise e

Expand Down