Skip to content

Commit

Permalink
tests(firefox): unskip network idle tests (#1832)
Browse files Browse the repository at this point in the history
  • Loading branch information
yury-s authored Apr 16, 2020
1 parent e67603d commit 04ed683
Showing 1 changed file with 2 additions and 6 deletions.
8 changes: 2 additions & 6 deletions test/navigation.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -557,19 +557,15 @@ describe('Page.goto', function() {
return page.setContent(`<script src='networkidle.js'></script>`, { waitUntil: 'networkidle2' });
}, true);
});
it.fail(FFOX)('should wait for networkidle0 in setContent with request from previous navigation', async({page, server}) => {
// TODO: in Firefox window.stop() does not cancel outstanding requests, and we also lack 'init' lifecycle,
// therefore we don't clear inflight requests at the right time.
it('should wait for networkidle0 in setContent with request from previous navigation', async({page, server}) => {
await page.goto(server.EMPTY_PAGE);
server.setRoute('/foo.js', () => {});
await page.setContent(`<script>fetch('foo.js');</script>`);
await networkIdleTest(page.mainFrame(), server, 'networkidle0', () => {
return page.setContent(`<script src='networkidle.js'></script>`, { waitUntil: 'networkidle0' });
}, true);
});
it.fail(FFOX)('should wait for networkidle2 in setContent with request from previous navigation', async({page, server}) => {
// TODO: in Firefox window.stop() does not cancel outstanding requests, and we also lack 'init' lifecycle,
// therefore we don't clear inflight requests at the right time.
it('should wait for networkidle2 in setContent with request from previous navigation', async({page, server}) => {
await page.goto(server.EMPTY_PAGE);
server.setRoute('/foo.js', () => {});
await page.setContent(`<script>fetch('foo.js');</script>`);
Expand Down

0 comments on commit 04ed683

Please sign in to comment.