Skip to content

Commit

Permalink
browser(firefox): handle message manager error event without error (#…
Browse files Browse the repository at this point in the history
…1344)

Type TypeError that happens while loading document is reported in
the message manager but does not have the error event.

Saw this while reproducing #1307
  • Loading branch information
aslushnikov authored Mar 11, 2020
1 parent 6b50c8f commit 3b85bf9
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion browser_patches/firefox/BUILD_NUMBER
Original file line number Diff line number Diff line change
@@ -1 +1 @@
1041
1042
4 changes: 2 additions & 2 deletions browser_patches/firefox/patches/bootstrap.diff
Original file line number Diff line number Diff line change
Expand Up @@ -2458,7 +2458,7 @@ index 0000000000000000000000000000000000000000..be70ea364f9534bb3b344f64970366c3
+
diff --git a/juggler/content/PageAgent.js b/juggler/content/PageAgent.js
new file mode 100644
index 0000000000000000000000000000000000000000..05c814d2b6a3df8d770acba723051eb52063bd4f
index 0000000000000000000000000000000000000000..3cafc06be2262a79e8459eb9afc03d424bc01303
--- /dev/null
+++ b/juggler/content/PageAgent.js
@@ -0,0 +1,919 @@
Expand Down Expand Up @@ -2821,7 +2821,7 @@ index 0000000000000000000000000000000000000000..05c814d2b6a3df8d770acba723051eb5
+ this._browserPage.emit('pageUncaughtError', {
+ frameId: frame.id(),
+ message: errorEvent.message,
+ stack: errorEvent.error.stack
+ stack: errorEvent.error ? errorEvent.error.stack : '',
+ });
+ }
+
Expand Down

0 comments on commit 3b85bf9

Please sign in to comment.