feat(firefox): roll Firefox to r1244 (#6052)

Fixes #5929
Fixes #6001

README.md

@@ -1,6 +1,6 @@
 # 🎭 Playwright
 
-[![npm version](https://img.shields.io/npm/v/playwright.svg?style=flat)](https://www.npmjs.com/package/playwright) [![Join Slack](https://img.shields.io/badge/join-slack-infomational)](https://aka.ms/playwright-slack) <!-- GEN:chromium-version-badge -->[![Chromium version](https://img.shields.io/badge/chromium-91.0.4455.0-blue.svg?logo=google-chrome)](https://www.chromium.org/Home)<!-- GEN:stop --> <!-- GEN:firefox-version-badge -->[![Firefox version](https://img.shields.io/badge/firefox-87.0b10-blue.svg?logo=mozilla-firefox)](https://www.mozilla.org/en-US/firefox/new/)<!-- GEN:stop --> <!-- GEN:webkit-version-badge -->[![WebKit version](https://img.shields.io/badge/webkit-14.2-blue.svg?logo=safari)](https://webkit.org/)<!-- GEN:stop -->
+[![npm version](https://img.shields.io/npm/v/playwright.svg?style=flat)](https://www.npmjs.com/package/playwright) [![Join Slack](https://img.shields.io/badge/join-slack-infomational)](https://aka.ms/playwright-slack) <!-- GEN:chromium-version-badge -->[![Chromium version](https://img.shields.io/badge/chromium-91.0.4455.0-blue.svg?logo=google-chrome)](https://www.chromium.org/Home)<!-- GEN:stop --> <!-- GEN:firefox-version-badge -->[![Firefox version](https://img.shields.io/badge/firefox-88.0b6-blue.svg?logo=mozilla-firefox)](https://www.mozilla.org/en-US/firefox/new/)<!-- GEN:stop --> <!-- GEN:webkit-version-badge -->[![WebKit version](https://img.shields.io/badge/webkit-14.2-blue.svg?logo=safari)](https://webkit.org/)<!-- GEN:stop -->
 
 ## [Documentation](https://playwright.dev) | [API reference](https://playwright.dev/docs/api/class-playwright/)
 
@@ -10,7 +10,7 @@ Playwright is a Node.js library to automate [Chromium](https://www.chromium.org/
 |   :---   | :---: | :---: | :---:   |
 | Chromium <!-- GEN:chromium-version -->91.0.4455.0<!-- GEN:stop --> | :white_check_mark: | :white_check_mark: | :white_check_mark: |
 | WebKit <!-- GEN:webkit-version -->14.2<!-- GEN:stop --> | :white_check_mark: | :white_check_mark: | :white_check_mark: |
-| Firefox <!-- GEN:firefox-version -->87.0b10<!-- GEN:stop --> | :white_check_mark: | :white_check_mark: | :white_check_mark: |
+| Firefox <!-- GEN:firefox-version -->88.0b6<!-- GEN:stop --> | :white_check_mark: | :white_check_mark: | :white_check_mark: |
 
 Headless execution is supported for all the browsers on all platforms. Check out [system requirements](https://playwright.dev/docs/intro/#system-requirements) for details.
 

browsers.json

@@ -8,7 +8,7 @@
     },
     {
       "name": "firefox",
-      "revision": "1239",
+      "revision": "1244",
       "installByDefault": true
     },
     {

src/server/firefox/protocol.ts

@@ -194,7 +194,7 @@ export module Protocol {
           width: number;
           height: number;
         };
-        deviceScaleFactor: number;
+        deviceScaleFactor?: number;
       }|null;
     };
     export type setDefaultViewportReturnValue = void;
@@ -294,7 +294,7 @@ export module Protocol {
         width: number;
         height: number;
       };
-      deviceScaleFactor: number;
+      deviceScaleFactor?: number;
     };
     export type DOMQuad = {
       p1: {
@@ -530,18 +530,6 @@ export module Protocol {
       frameId: string;
     };
     export type reloadReturnValue = void;
-    export type getBoundingBoxParameters = {
-      frameId: string;
-      objectId: string;
-    };
-    export type getBoundingBoxReturnValue = {
-      boundingBox: {
-        x: number;
-        y: number;
-        width: number;
-        height: number;
-      }|null;
-    };
     export type adoptNodeParameters = {
       frameId: string;
       objectId: string;
@@ -558,13 +546,13 @@ export module Protocol {
     };
     export type screenshotParameters = {
       mimeType: ("image/png"|"image/jpeg");
-      fullPage?: boolean;
       clip?: {
         x: number;
         y: number;
         width: number;
         height: number;
       };
+      omitDeviceScaleFactor?: boolean;
     };
     export type screenshotReturnValue = {
       data: string;
@@ -1068,7 +1056,6 @@ export module Protocol {
     "Page.goBack": Page.goBackParameters;
     "Page.goForward": Page.goForwardParameters;
     "Page.reload": Page.reloadParameters;
-    "Page.getBoundingBox": Page.getBoundingBoxParameters;
     "Page.adoptNode": Page.adoptNodeParameters;
     "Page.screenshot": Page.screenshotParameters;
     "Page.getContentQuads": Page.getContentQuadsParameters;
@@ -1142,7 +1129,6 @@ export module Protocol {
     "Page.goBack": Page.goBackReturnValue;
     "Page.goForward": Page.goForwardReturnValue;
     "Page.reload": Page.reloadReturnValue;
-    "Page.getBoundingBox": Page.getBoundingBoxReturnValue;
     "Page.adoptNode": Page.adoptNodeReturnValue;
     "Page.screenshot": Page.screenshotReturnValue;
     "Page.getContentQuads": Page.getContentQuadsReturnValue;

test/beforeunload.spec.ts

@@ -65,7 +65,7 @@ it('should run beforeunload if asked for', async ({context, server, isChromium,
   else if (isWebKit)
     expect(dialog.message()).toBe('Leave?');
   else
-    expect(dialog.message()).toBe('This page is asking you to confirm that you want to leave - data you have entered may not be saved.');
+    expect(dialog.message()).toBe('This page is asking you to confirm that you want to leave — information you’ve entered may not be saved.');
   await Promise.all([
     dialog.accept(),
     newPage.waitForEvent('close'),

test/workers.spec.ts

@@ -54,9 +54,7 @@ it('should report console logs', async function({page}) {
   expect(page.url()).not.toContain('blob');
 });
 
-it('should not report console logs from workers twice', (test, {browserName}) => {
-  test.fail(browserName === 'firefox');
-}, async function({page}) {
+it('should not report console logs from workers twice', async function({page}) {
   const messages = [];
   page.on('console', msg => messages.push(msg.text()));
   await Promise.all([